Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify handling of pylibdirs and don't add duplicated $PYTHONPATH in PythonBundle #2281

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Unify handling of pylibdirs and don't add duplicated $PYTHONPATH in PythonBundle #2281

merged 1 commit into from
Dec 18, 2020
+29 −20

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Dec 15, 2020 •
edited
Loading

(created using eb --new-pr)

Bug introduced in #2075

Ccing @boegel

akesandgren
akesandgren approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren akesandgren added this to the next release (4.3.3?) milestone Dec 18, 2020
@akesandgren
Copy link
Contributor

Going in, thanks @Flamefire!

@akesandgren akesandgren merged commit cebc18e into easybuilders:develop Dec 18, 2020
@Flamefire Flamefire deleted the 20201215171259_new_pr_VVGiSrOPeG branch December 18, 2020 16:17
@boegel boegel changed the title Unify handling of pylibdirs and don't add duplicated PYTHONPATH in PythonBundle Unify handling of pylibdirs and don't add duplicated $PYTHONPATH in PythonBundle Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Flamefire @akesandgren